Fix the issue that missing identifiers from ANTLR keywords#821
Merged
LantaoJin merged 1 commit intoopensearch-project:mainfrom Oct 29, 2024
Merged
Fix the issue that missing identifiers from ANTLR keywords#821LantaoJin merged 1 commit intoopensearch-project:mainfrom
LantaoJin merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
commented
Oct 28, 2024
Comment on lines
-77
to
-82
| VALUE: 'VALUE'; | ||
| USING: 'USING'; | ||
| WITH: 'WITH'; | ||
|
|
||
| // CLAUSE KEYWORDS | ||
| SORTBY: 'SORTBY'; |
Member
Author
There was a problem hiding this comment.
These two keywords are not used at all in parser.
LantaoJin
commented
Oct 28, 2024
| | fieldsummaryCommand | ||
| ; | ||
|
|
||
| commandName |
Member
Author
There was a problem hiding this comment.
Add a new variable commandName, all new command (not function) should be added in this list.
LantaoJin
commented
Oct 28, 2024
Comment on lines
-363
to
-369
| takeAggFunction | ||
| : TAKE LT_PRTHS fieldExpression (COMMA size = integerLiteral)? RT_PRTHS | ||
| ; | ||
|
|
||
| percentileAggFunction | ||
| : PERCENTILE LESS value = integerLiteral GREATER LT_PRTHS aggField = fieldExpression RT_PRTHS | ||
| ; |
Member
There was a problem hiding this comment.
@kt-eliatra @salyh please make sure why this is not in use
Contributor
There was a problem hiding this comment.
Thats not from us and in the g4 files there are plenty of unused statements. And also unused code in the code base btw :-)
Contributor
There was a problem hiding this comment.
percentileAgg != percentile (see blame)
LantaoJin
added
maintenance
LantaoJin
requested review from
YANG-DB,
anirudha,
dai-chen,
kaituo,
mengweieric,
noCharger,
penghuo,
rupal-bq,
seankao-az,
vamsimanohar and
ykmr1224
as code owners
YANG-DB
approved these changes
Oct 28, 2024
YANG-DB
approved these changes
Oct 28, 2024
kenrickyap
pushed a commit
to Bit-Quill/opensearch-spark
that referenced
this pull request
Dec 11, 2024
…h-project#821) Signed-off-by: Lantao Jin <ltjin@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is sourcing from fixing the problem introduced by #723:
| stats sum(1) as valuefailed due to #723 introduced a keywordVALUEbut not marked as Id in ANTLR file.Then I identified there are not only
VALUE, but also more invalid keywords as identifier in g4 file.Related Issues
Resolves #820
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.